Skip to content

More response file support in asyncify: whitelist/blacklist #2335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kripken merged 4 commits into from
Sep 8, 2019
Merged

More response file support in asyncify: whitelist/blacklist #2335

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b0bb25e
more
kripken Aug 31, 2019
f7be6c4
Merge remote-tracking branch 'origin/master' into more
kripken Sep 6, 2019
35d6034
fix
kripken Sep 6, 2019
7f1c122
style
kripken Sep 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/passes/Asyncify.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,12 +231,16 @@
// really know what are doing, and need to optimize every bit of speed
// and size.
//
// As with --asyncify-imports, you can use a response file here.
//
// --pass-arg=asyncify-whitelist@name1,name2,name3
//
// If the whitelist is provided, then only the functions in the list
// will be instrumented. Like the blacklist, getting this wrong will
// break your application.
//
// As with --asyncify-imports, you can use a response file here.
//
// TODO When wasm has GC, extending the live ranges of locals can keep things
// alive unnecessarily. We may want to set locals to null at the end
// of their original range.
Expand Down Expand Up @@ -1047,9 +1051,13 @@ struct Asyncify : public Pass {
auto ignoreIndirect =
runner->options.getArgumentOrDefault("asyncify-ignore-indirect", "");
String::Split blacklist(
runner->options.getArgumentOrDefault("asyncify-blacklist", ""), ",");
String::trim(read_possible_response_file(
runner->options.getArgumentOrDefault("asyncify-blacklist", ""))),
",");
String::Split whitelist(
runner->options.getArgumentOrDefault("asyncify-whitelist", ""), ",");
String::trim(read_possible_response_file(
runner->options.getArgumentOrDefault("asyncify-whitelist", ""))),
",");

blacklist = handleBracketingOperators(blacklist);
whitelist = handleBracketingOperators(whitelist);
Expand Down