vNxM.load_splat instructions#2350
Merged
tlively merged 1 commit intoWebAssembly:masterfrom Sep 24, 2019
Merged
Conversation
Introduces a new instruction class, `SIMDLoad`. Implements encoding, decoding, parsing, printing, and interpretation of the load and splat instructions, including in the C and JS APIs. `v128.load` remains in the `Load` instruction class for now because the interpreter code expects a `Load` to be able to load any memory value type.
kripken
approved these changes
Sep 23, 2019
| load.align = curr->align; | ||
| load.isAtomic = false; | ||
| load.ptr = curr->ptr; | ||
| Literal (Literal::*splat)() const = nullptr; |
Member
There was a problem hiding this comment.
Fancy... but I guess it's nice here :)
| - [ ] JS API support added in build-js.sh and src/js/binaryen.js-post.js | ||
| - [ ] C API tested in test/example/c-api-kitchen-sink.c | ||
| - [ ] JS API tested in test/binaryen.js/kitchen-sink.js | ||
| - [ ] Tests added in test/spec |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a new instruction class,
SIMDLoad. Implements encoding,decoding, parsing, printing, and interpretation of the load and splat
instructions, including in the C and JS APIs.
v128.loadremains inthe
Loadinstruction class for now because the interpreter codeexpects a
Loadto be able to load any memory value type.