Ability to list each item on Exports/Data Segments/Functions#2386
Ability to list each item on Exports/Data Segments/Functions#2386tlively merged 11 commits intoWebAssembly:masterfrom COFFEETALES:js-list-each-item
Conversation
tlively
left a comment
There was a problem hiding this comment.
Small comments inline. Please also add tests in test/binaryen.js/kitchen-sink.js and test/example/c-api-kitchen-sink.c.
tlively
left a comment
There was a problem hiding this comment.
Looks great! Just one last readability comment on the tests and I think we're good to go.
|
Sorry, I noticed a few more C++ issues. This is the last of it for real now 👍 |
|
While creating the respective bindings for AssemblyScript, I noticed that there is int64_t BinaryenGetMemorySegmentByteOffset(BinaryenModuleRef module,
BinaryenIndex id) {returning an |
|
@dcodeIO The returned value will contain the lower 32 bits, though, so it should just work for you (with wasm32 for sure). |
|
This is fixed by #2432. |
|
Thanks! 🎉 Being so cautious here because |
It gives the possibility to list several contents in a decoded module.
Some examples of the use of the JS api: