Conversation
This reverts commit f0ceedc.
|
cc @dcodeIO |
|
Compiling to Wasm exclusively sounds good to me. Two questions:
|
|
I remember the if (!Binaryen.isReady) await Binaryen.ready;
...
Git for Windows includes Git Bash, which makes a bash file quite convenient. Is there maybe a way to make this a cmake task, conditionally creating a VS project? Would be similar since one needs cmake anyway to build parts of Binaryen. I don't know much about this, unfortunately |
|
I see, thanks. Ok, sounds like this PR isn't the right way to go - I'll close this, and open issues for those ideas, which I agree are the right way to go. Not sure I'll have time for them myself, though. |
This cleans up and refactors the binaryen.js build script to be
a proper Makefile. Aside from cleanliness, the main benefits
are:
make -jX.the wasm backend is broken on js builds, so this works around
that until we solve it. However, maybe we just want the build
to be wasm anyhow? Binaryen.js builds with wasm2js fail #2446