Fix #2450#2477
Merged
kripken merged 1 commit intoWebAssembly:masterfrom Nov 27, 2019
ImmanuelHaffner:libbinaryen-monolithic
Merged
Fix #2450#2477kripken merged 1 commit intoWebAssembly:masterfrom ImmanuelHaffner:libbinaryen-monolithic
kripken merged 1 commit intoWebAssembly:masterfrom
ImmanuelHaffner:libbinaryen-monolithic
Conversation
using the `$<TARGET_OBJECTS:objlib>` syntax. Use this variable when adding `libbinaryen` as static or shared library. Additionally, use the variable with the object files to simplify the `TARGET_LINK_LIBRARIES` commands: add the object libraries to the sources of executables and drop the use of our libraries in `TARGET_LINK_LIBRARIES`. (Object libraries cannot be linked but must be used as sources. See https://cmake.org/pipermail/cmake/2018-June/067721.html)
Member
|
Thanks! Looks good to me, but we should verify that this works on the Mac bot. Sadly those seem to be very slow, but hopefully later today it'll finish. |
kripken
approved these changes
Nov 26, 2019
Member
|
Well, no luck on the mac bot on CI, but this looks safe and @aheejin tested locally on a mac, so let's merge and see what happens 😄 |
Contributor
Author
|
Glad I could help. Let's hope for the best. Maybe this has something to do with the version of CMake or Make/Ninja? I guess we can just wait for a new issue to be filed :D In case someone wants to know how to use Binaryen as CMake |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build all libraries of subdirectories as
OBJECTlibraries. Collect all object files from the object libraries in a CMake variable using the$<TARGET_OBJECTS:objlib>syntax. Use this variable whenadding
libbinaryenas static or shared library. Additionally, use thevariable with the object files to simplify the
TARGET_LINK_LIBRARIEScommands: add the object libraries to the sources of executables and
drop the use of our libraries in
TARGET_LINK_LIBRARIES. (Objectlibraries cannot be linked but must be used as sources. See
https://cmake.org/pipermail/cmake/2018-June/067721.html)
This fixes #2450