Skip to content

Fix CMake command line issue with EXPORT_NAME on Windows#2485

Merged
kripken merged 1 commit intoWebAssembly:masterfrom
dcodeIO:cmakelists-windows
Dec 2, 2019
Merged

Fix CMake command line issue with EXPORT_NAME on Windows#2485
kripken merged 1 commit intoWebAssembly:masterfrom
dcodeIO:cmakelists-windows

Conversation

@dcodeIO
Copy link
Copy Markdown
Contributor

@dcodeIO dcodeIO commented Nov 28, 2019

On Windows, if there's just cmd, the syntax -s 'EXPORT_NAME="Binaryen"' is invalid due to the single quotes.

shared:ERROR: Attempt to set a non-existent setting: ''EXPORT_NAME'
 - did you mean one of EXPORT_NAME, EXPORT_ES6, EXPORT_ALL?
 - perhaps a typo in emcc's  -s X=Y  notation?
 - (see src/settings.js for valid values)
ninja: build stopped: subcommand failed.

This removes the quotes, but I am not sure if this is still valid (on Linux). Perhaps CI will tell :)

Copy link
Copy Markdown
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@kripken kripken merged commit 86492f7 into WebAssembly:master Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants