Skip to content

cmake: Convert to using lowercase for and functions/macros#2495

Merged
sbc100 merged 1 commit intomasterfrom
update_cmake_formatting
Dec 4, 2019
Merged

cmake: Convert to using lowercase for and functions/macros#2495
sbc100 merged 1 commit intomasterfrom
update_cmake_formatting

Conversation

@sbc100
Copy link
Copy Markdown
Member

@sbc100 sbc100 commented Dec 4, 2019

This is line with modern cmake conventions is much less SHOUTY!

@sbc100 sbc100 requested a review from kripken December 4, 2019 01:59
This is line with modern cmake conventions is much less SHOUTY!
@sbc100 sbc100 force-pushed the update_cmake_formatting branch from 7a247d9 to bb43d7d Compare December 4, 2019 02:11
@sbc100
Copy link
Copy Markdown
Member Author

sbc100 commented Dec 4, 2019

ping...

Copy link
Copy Markdown
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the modern convention lowercase? lgtm!

@sbc100 sbc100 merged commit a2f1a63 into master Dec 4, 2019
@sbc100 sbc100 deleted the update_cmake_formatting branch December 4, 2019 20:49
sbc100 added a commit that referenced this pull request Jan 25, 2021
Followup on original conversion done in #2495.
sbc100 added a commit that referenced this pull request Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants