Conversation
jgravelle-google
approved these changes
Dec 5, 2019
Contributor
jgravelle-google
left a comment
jgravelle-google
left a comment
There was a problem hiding this comment.
Yay debugging/instrumentation
| std::cerr << "Module before:\n"; | ||
| WasmPrinter::printModule(&wasm, std::cerr); | ||
| } | ||
| // Useful for debugging |
Contributor
There was a problem hiding this comment.
It feels weird to go from a runtime check to a compile-time thing here. Maybe add a new runtime option here? --dump-module?
I do agree that I usually don't want a pre-module dump, so I do support decoupling debug from dump here.
Also we should update the "Module after" dump to BYN_TRACE + BYN_DEBUG too? (Line293, can't comment it directly)
kripken
reviewed
Dec 5, 2019
jgravelle-google
approved these changes
Dec 5, 2019
Also fix, but in splitting the names of the trace channels. Obviously I can't write string.split correctly in C first time around.
tlively
approved these changes
Dec 6, 2019
| type_end = types + end; | ||
| } | ||
| size_t type_size = type_end - types + start; | ||
| size_t type_size = type_end - (types + start); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fix, but in splitting the names of the trace channels. Obviously
I can't write string.split correctly in C first time around.