Skip to content

Use wat over wast for text format filenames#2518

Merged
sbc100 merged 1 commit intomasterfrom
wast_to_wat
Dec 9, 2019
Merged

Use wat over wast for text format filenames#2518
sbc100 merged 1 commit intomasterfrom
wast_to_wat

Conversation

@sbc100
Copy link
Copy Markdown
Member

@sbc100 sbc100 commented Dec 8, 2019

No description provided.

@sbc100 sbc100 requested a review from tlively December 8, 2019 03:06
@sbc100
Copy link
Copy Markdown
Member Author

sbc100 commented Dec 8, 2019

I'm sure I've missed some uses here, but I wanted to be conservative because some uses of wast really are wast files rather than single-module wat files.

@sbc100 sbc100 merged commit 42b61e3 into master Dec 9, 2019
@sbc100 sbc100 deleted the wast_to_wat branch December 9, 2019 02:50
sbc100 added a commit that referenced this pull request Dec 10, 2019
@aheejin
Copy link
Copy Markdown
Member

aheejin commented Jan 6, 2020

What are the differences between wast and wat files now? Is it ok for wat files not in valid wat format parsable by wabt?

@sbc100
Copy link
Copy Markdown
Member Author

sbc100 commented Jan 8, 2020

IIUC, wat is for a single module and wast is for a file that contain any number of modules and/or assertions.

I'm not sure about the second question. Any wat file not in valid should generate parse error in wabt (unless some special option is given such as --no-check perhaps?)

@aheejin
Copy link
Copy Markdown
Member

aheejin commented Jan 8, 2020

Hmm, I had an (incorrect) impression that the s-expression format Binaryen uses is the wast format and the straight-line format Wabt uses is the wat format. But it seems Wabt also can parse s-expression format Binaryen uses (although not all of them currently).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants