Refactor module element related functions (NFC)#2550
Merged
aheejin merged 2 commits intoWebAssembly:masterfrom Dec 23, 2019
Merged
Refactor module element related functions (NFC)#2550aheejin merged 2 commits intoWebAssembly:masterfrom
aheejin merged 2 commits intoWebAssembly:masterfrom
Conversation
This does something similar to WebAssembly#2489 for more functions, removing boilerplate code for each module element using template functions.
aheejin
force-pushed
the
refactor_module
branch
from
686a6fe to
595bb5a
Compare
kripken
approved these changes
Dec 23, 2019
| Fatal() << "Module::getExport: " << name << " does not exist"; | ||
| template<typename Map> | ||
| typename Map::mapped_type& | ||
| getModuleElement(Map& m, Name name, std::string funcName) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does something similar to #2489 for more functions, removing
boilerplate code for each module element using template functions.