Conversation
| std::cout << "[asyncify] " << func->name | ||
| << "'s state is set based on the only-list to " << matched | ||
| << '\n'; | ||
| } |
There was a problem hiding this comment.
Is looks possible for some functions to be logged as added as can-change-state functions but if the only-list is present, they are eventually ignored silently, i.e., without any other log messages that they are ignored, right? Would it be better to check the only list when logging for other causes..?
There was a problem hiding this comment.
I think this log message here would be shown, though, so it's not completely silent? This message would say they are set to false, which overrides the previous messages.
There was a problem hiding this comment.
Ah you're right. Sorry I thought this is only printed when the value is true.
|
Yes, the "due to" will be super useful in tracking down why a function that doesn't appear necessary is included, thanks! |
This logs out the decisions made about instrumenting functions, which
can help figure out why a function is instrumented, or to get a list of
what might need to be.
As the test shows, it can print things like this:
(the test has
calls-calls-calls-import => calls-calls-import => calls-import -> import).Not sure how useful this might be, but it was easy to write up. Thoughts?
cc @curiousdannii @aardappel