Stop generating __growWasmMemory #3180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
Sep 30, 2020
sbc100
added a commit
that referenced
this pull request
Oct 1, 2020
This will allow for the completely removal of `__growWasmMemory` as a followup. We currently unconditionally generate this function in `generateMemoryGrowthFunction`. See #3180
sbc100
force-pushed
the
remove_grow_memory
branch
from
6b7deb8 to
df79946
Compare
kripken
approved these changes
Oct 1, 2020
This depends on emscripten-core/emscripten#12391
sbc100
force-pushed
the
remove_grow_memory
branch
from
df79946 to
c960dfd
Compare
Member
Author
|
This is going to cause a log of size improvements on the emscripten side so I guess I'll need to PR there to disable some codesize tests... looking into it now. |
sbc100
added a commit
to emscripten-core/emscripten
that referenced
this pull request
Oct 1, 2020
sbc100
added a commit
to emscripten-core/emscripten
that referenced
this pull request
Oct 1, 2020
sbc100
added a commit
that referenced
this pull request
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: emscripten-core/emscripten#12378