-
Notifications
You must be signed in to change notification settings - Fork 828
[OptimizeInstructions] Combine extend to i64 and 32-bit load operations #4307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OptimizeInstructions] Combine extend to i64 and 32-bit load operations #4307
Conversation
|
Are you sure about these?
For example:
The same applies to the 16-bit case. |
|
@lexaknyazev Yes, such pairs of operations we should avoid |
|
Fuzzed |
kripken
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks good!
Please fuzz the last version, unless you already have?
|
Ok, I'll refuzz this tomorrow |
|
Hmm, I got this: [wasm-validator error in function 57] unexpected true: atomic loads must be unsigned, on
(i64.atomic.load32_s offset=22
(i32.and
(i32.const -66)
(i32.const 15)
)
)for Upd: Oh atomics doesn't have sign extended versions for loads! |
|
Refuzzed |
don't apply to