[NFC] Move value numbering code to a header #4345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aheejin
approved these changes
Nov 19, 2021
tlively
approved these changes
Nov 19, 2021
src/ir/numbering.h
Outdated
Comment on lines
58
to
59
| // Reserve 0 for possible future use as a "null value". | ||
| Index nextValue = 1; |
Member
There was a problem hiding this comment.
There should be no need to reserve a value now, even if we plan to introduce a special meaning in the future. These values should be opaque to all users, so changing them shouldn't break anything.
Member
Author
There was a problem hiding this comment.
Fair point, yeah. I do find it useful to not use 0 when debugging locally, I guess mentally 0 feels "special" to me. I'll improve the comment.
Member
Author
There was a problem hiding this comment.
I just made it 0 for now, actually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just moves code out of RedundantSetElimination. This code will be
useful in a future PR to improve CoalesceLocals in the direction suggested
by @tlively in #4314 (comment)