[OptimizeInstructions] Combine some relational ops joined Or/And (Part 7-8) #4399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Fuzzed: @kripken could you take a look please? |
kripken
reviewed
Jan 25, 2022
| (i32.ge_s (local.get $y) (i32.const 0)) | ||
| )) | ||
| ;; (i64(x) >= 0) & (i64(y) >= 0) ==> i64(x | y) >= 0 | ||
| (drop (i32.and |
Member
There was a problem hiding this comment.
Shouldn't this be i64? Does binaryen not error on this?
Contributor
Author
There was a problem hiding this comment.
No, result type of LHS and RHS comparisons are i32. Also all this optimizations only apply for i32 and / or.
Member
There was a problem hiding this comment.
Oh, thanks, I forgot that the comparisons return a bool, which is i32...
kripken
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is final part of #4265