Replace i31.new with ref.i31 everywhere #5931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
Codecov Report
@@ Coverage Diff @@
## main #5931 +/- ##
==========================================
- Coverage 42.60% 42.60% -0.01%
==========================================
Files 484 484
Lines 74815 74823 +8
Branches 11919 11920 +1
==========================================
+ Hits 31872 31875 +3
- Misses 39746 39751 +5
Partials 3197 3197
|
kripken
approved these changes
Sep 12, 2023
tlively
force-pushed
the
ref-i31-external
branch
from
7362824 to
71a0c16
Compare
tlively
force-pushed
the
ref-i31-internal
branch
from
5ef517d to
5dda037
Compare
tlively
force-pushed
the
ref-i31-external
branch
from
71a0c16 to
1c06848
Compare
Replace i31.new with ref.i31 in the printer, tests, and source code. Continue parsing i31.new for the time being to allow a graceful transition. Also update the JS API to reflect the new instruction name.
tlively
force-pushed
the
ref-i31-external
branch
from
1c06848 to
33fcbfe
Compare
radekdoulik
pushed a commit
to dotnet/binaryen
that referenced
this pull request
Jul 12, 2024
Replace i31.new with ref.i31 in the printer, tests, and source code. Continue parsing i31.new for the time being to allow a graceful transition. Also update the JS API to reflect the new instruction name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace i31.new with ref.i31 in the printer, tests, and source code. Continue
parsing i31.new for the time being to allow a graceful transition. Also update
the JS API to reflect the new instruction name.