Fuzz the Table from JS #7042
Merged
Fuzz the Table from JS #7042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aheejin
approved these changes
Oct 31, 2024
Comment on lines
+624
to
+628
| // If a "table" export already exists, skip fuzzing these imports, as the | ||
| // current export may not contain a valid table for it. | ||
| if (wasm.getExportOrNull("table")) { | ||
| return; | ||
| } |
Member
Author
There was a problem hiding this comment.
The fuzzer can start with inputs from the test suite and elsewhere, and initial content like that can contain a "table" export. Basically, the fuzzer needs to be able to start from any valid wasm file, so we have to handle corner cases like that.
|
|
||
| // Table operations. | ||
| 'table-get': (index) => { | ||
| return exports.table.get(index >>> 0); |
Member
There was a problem hiding this comment.
What's the reason for shifting the index by 0? (I googled it and it says it makes it a number, but I don't understand why it is necessary...)
Member
Author
There was a problem hiding this comment.
the >>> operator is an unsigned operation, so this forces it to be a 32-bit unsigned number. That is the same way that the wasm table.get operation treats the input, so this is done to match that.
aheejin
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues the work from #7027 which added throwing from JS, this adds
table get/set operations from JS, to further increase our coverage of
Wasm/JS interactions (the table can be used from both sides).