Fix IRBuilder on local operations outside of a function context#7183
Merged
kripken merged 2 commits intoWebAssembly:mainfrom Jan 6, 2025
Merged
Fix IRBuilder on local operations outside of a function context#7183kripken merged 2 commits intoWebAssembly:mainfrom
kripken merged 2 commits intoWebAssembly:mainfrom
Conversation
tlively
approved these changes
Jan 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IRBuilder needs to check for a function context before doing
func->getLocalType(). Without such a check, a bad binary with a localoperation in say a global init would lead to a crash.
We don't actually need this for
local.set, unliketeeandget, sinceit doesn't call
getLocalType, but this PR adds that too for consistencyof errors.
No other operations in IRBuilder were missing this check aside from
local operations.
Fixes #7178