[EH] Fuzzer: Fix infinite loop with nested exnrefs#7294
Merged
kripken merged 1 commit intoWebAssembly:mainfrom Feb 14, 2025
Merged
[EH] Fuzzer: Fix infinite loop with nested exnrefs#7294kripken merged 1 commit intoWebAssembly:mainfrom
kripken merged 1 commit intoWebAssembly:mainfrom
Conversation
aheejin
approved these changes
Feb 14, 2025
Member
aheejin
left a comment
There was a problem hiding this comment.
LGTM. By the way I think we had a restriction that that when GC is not enabled, a tag type cannot contain exnref because it can for cycles (and when there's no GC we have to rely on refcounting)... But I don't think we ended up actually writing that in the spec because we don't have "EH spec without GC" version. Not sure whether that's worth implementing in the fuzzing purpose though.
Member
Author
|
Oh, interesting about cycles. I guess disallowing exnref in tags in the fuzzer could have also avoided this, at least for non-GC... but the PR should handle the GC case too, so that's probably enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we need an exnref value we may create a try-catch with a throw (so
when we catch it, we get an exnref). But if the exception tag contains an
exnref, then we will try to create another exnref in the throw, leading to
recursion (possibly infinite). To avoid this, just create a trivial tag with no
values when we just want a trivial value.