Skip to content

Fuzzer: Fix root cause of emitting non-constant expressions in global positions#7884

Merged
kripken merged 1 commit intoWebAssembly:mainfrom
kripken:fuzz.constglob
Sep 5, 2025
Merged

Fuzzer: Fix root cause of emitting non-constant expressions in global positions#7884
kripken merged 1 commit intoWebAssembly:mainfrom
kripken:fuzz.constglob

Conversation

@kripken
Copy link
Copy Markdown
Member

@kripken kripken commented Sep 5, 2025

When we create a global we properly do value = makeConst(). However, if
we have nested structs, we ended up possibly calling make(field.type),
which could emit anything.

To fix that, check for a function context in the core make().

Replaces #7817

Copy link
Copy Markdown
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@kripken kripken merged commit b1e24dc into WebAssembly:main Sep 5, 2025
16 checks passed
@kripken kripken deleted the fuzz.constglob branch September 5, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants