[emscripten] Avoid copying binaryen.js for each test. NFC #7987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
Oct 22, 2025
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
Which version are you testing with? IIUC node changed the behavior at some point.
Member
Author
|
I tested with my locally installed version: |
Member
Author
|
You are right it looks like this fails on node older than v20... do we care about testing on such old versions? |
Member
|
Maybe not, yeah. Is 20 the default in most distros etc? I seem to recall we checked that... |
Member
Author
|
I guess we will see if the emscripten tests fail.. if the CI machine has < v20 than I guess we need to keep this hack. |
Turns out you can import a `.js` just fine under node. It doesn't need to be called `.mjs`, despite the comment.
Member
Author
|
OK, it looks like at least the CI machines have v20 and above. |
sbc100
force-pushed
the
avoid_copying_binaryen_js
branch
from
b4a2d79 to
52d06bf
Compare
kripken
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out you can import a
.jsjust fine under node. It doesn't need to be called.mjs, despite the comment.