Skip to content

[emscripten] Avoid copying binaryen.js for each test. NFC #7987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2025
Merged

[emscripten] Avoid copying binaryen.js for each test. NFC #7987

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions scripts/test/binaryenjs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
# limitations under the License.

import os
import shutil
import subprocess

from . import shared
Expand All @@ -37,15 +36,10 @@ def make_js_test_header(binaryen_js):


def make_js_test(input_js_file, binaryen_js):
# Copy the binaryen.js file to binaryen.mjs for now since file
# extensions matter under node.
# TODO(sbc): Should binaryen build as a `.mjs` file itself?
shutil.copyfile(binaryen_js, 'binaryen.mjs')

basename = os.path.basename(input_js_file)
outname = os.path.splitext(basename)[0] + '.mjs'
with open(outname, 'w') as f:
f.write(make_js_test_header('./binaryen.mjs'))
f.write(make_js_test_header(binaryen_js))
test_src = open(input_js_file).read()
f.write(test_src)
return outname
Expand Down
Loading