[JS Interop] Optimize configureAll #8054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
approved these changes
Nov 17, 2025
Member
There was a problem hiding this comment.
Is there a way we can allow refining the result types but not the parameter types?
Member
Author
There was a problem hiding this comment.
We could with extra logic. Do you think it would be worth it?
Member
There was a problem hiding this comment.
I think it might be worth it. No reason to lose type information unnecessarily in the returns, and I assume it won't take much extra logic to implement.
Member
Author
There was a problem hiding this comment.
Ok, I'll look into a followup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the marking of all configureAll-referred functions as having public
heap types. It turns out that only 2 passes then need to be fixed, as the
others that care about public types either don't look at functions, or do not
care about signature-called functions (e.g. making the type final is not a
problem there).