[NFC] Make module-level annotations available #8262
Merged
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already had some code for collecting annotations on top-level module fields like functions, but they were only passed to the parsing context in the initial parsing phase. Fix the parser so that the annotations are passed in all phases. This was tested locally by printing function annotations, but will not be testable for real until we start doing something with the annotations. Fixes #8260.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already had some code for collecting annotations on top-level module
fields like functions, but they were only passed to the parsing context
in the initial parsing phase. Fix the parser so that the annotations are
passed in all phases. This was tested locally by printing function
annotations, but will not be testable for real until we start doing
something with the annotations.
Fixes #8260.