Remove checked-in binary for test/lld/em_asm_pthread.cpp. NFC#8392
Merged
Remove checked-in binary for test/lld/em_asm_pthread.cpp. NFC#8392
Conversation
This was was added back in #3714, but with a checked in binaryen instead of a .wat file This change fixes generate_lld_tests.py so that it can build em_asm_pthread.cpp currently and converts the test from a wasm to a wat test. The important part of the test I beleive is the `(start $__wasm_init_memory)` which exists in the new `.wat` file.
kripken
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was was added back in #3714, but with a checked in binaryen instead of a .wat file
This change fixes
generate_lld_tests.pyso that it can buildem_asm_pthread.cppcorrectly and converts the test from a wasm to a wat test.The important part of the test I beleive is the
(start $__wasm_init_memory)which exists in the new.watfile.