Skip to content

Initial support for (thread ...) and (wait ...) in WAST#8418

Merged
stevenfontanella merged 1 commit intomainfrom
thread-parse
Mar 5, 2026
Merged

Initial support for (thread ...) and (wait ...) in WAST#8418
stevenfontanella merged 1 commit intomainfrom
thread-parse

Conversation

@stevenfontanella
Copy link
Member

  • Parse (thread ...) and (wait ...) in spec tests
    • Currently, we just run thread blocks directly, which means that wait is also a no-op. In the next PR, we'll add yield points on atomic operations e.g. memory.atomic.wait32.
    • We also disable splitting on tests that use (thread ...) for now. It should be possible to support this but we need better parsing in the module splitter. I'll add this in a future PR.
  • Import threads tests from the threads repo. These currently aren't in the testsuite repo because the threads repo is far behind the upstream spec and has some merge conflicts.
  • Passes 10/13 new spec tests.

Part of #8315 and #8261.

@stevenfontanella stevenfontanella force-pushed the thread-parse branch 4 times, most recently from 6d075a8 to 9f16593 Compare March 4, 2026 23:46
@stevenfontanella stevenfontanella changed the title Add initial support for parsing (thread ...) and (wait ...) in WAST Initial support for (thread ...) and (wait ...) in WAST Mar 5, 2026
@stevenfontanella stevenfontanella marked this pull request as ready for review March 5, 2026 00:38
Copy link
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % comments.

@stevenfontanella stevenfontanella enabled auto-merge (squash) March 5, 2026 18:39
@stevenfontanella stevenfontanella merged commit cc866c7 into main Mar 5, 2026
17 checks passed
@stevenfontanella stevenfontanella deleted the thread-parse branch March 5, 2026 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants