Merged
Conversation
GTO already handled keeping the prototype configuration fields on descriptors of types that flowed out to JS via @binaryen.js.called functions, but it did not handle propagating the information that a type flows out to JS to that type's subtypes. It also did not consider that types may flow out to JS via imports and exports. Fix these issues.
kripken
reviewed
Mar 11, 2026
| if (global->imported() && global->mutable_) { | ||
| flowOut(global->type); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
I wonder if we can share this logic with your last PR? a general utility that finds the flow out/flow in JS stuff.
Member
Author
There was a problem hiding this comment.
Oh yes, that's a good idea. Do you mind if I do it as a follow-up?
kripken
reviewed
Mar 11, 2026
| (type $sub-desc (describes $sub) (struct (field externref i64))) | ||
| ) | ||
|
|
||
| ;; $super flows out, so $sub is exposed, so $sub-desc field is kept. |
Member
There was a problem hiding this comment.
Suggested change
| ;; $super flows out, so $sub is exposed, so $sub-desc field is kept. | |
| ;; $super flows out, so $sub is exposed, so $sub-desc's externref field is kept. |
kripken
reviewed
Mar 11, 2026
|
|
||
| (module | ||
| ;; Same, but now the type is exact on the boundary, so it does not propagate | ||
| ;; exposure to subtypes. We can optimize $sub-desc. |
Member
There was a problem hiding this comment.
Suggested change
| ;; exposure to subtypes. We can optimize $sub-desc. | |
| ;; exposure to subtypes. We can remove all $sub-desc's fields, unlike before. |
kripken
reviewed
Mar 11, 2026
|
|
||
| (module | ||
| ;; Same, but now there is an abstract supertype on the boundary. We still | ||
| ;; propagate expose and keep the externref field in $sub-desc. |
Member
Author
There was a problem hiding this comment.
Will fix to "propagate the fact that the type flows out..."
kripken
reviewed
Mar 12, 2026
kripken
reviewed
Mar 12, 2026
| ) | ||
|
|
||
| (module | ||
| ;; Now the supertype is a result of the imported function rather than a |
Member
There was a problem hiding this comment.
Suggested change
| ;; Now the supertype is a result of the imported function rather than a | |
| ;; Now the supertype is a result of the imported function's result rather than a |
Member
Author
There was a problem hiding this comment.
We already said "result" earlier in the sentence. Leaving as-is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GTO already handled keeping the prototype configuration fields on
descriptors of types that flowed out to JS via @binaryen.js.called
functions, but it did not handle propagating the information that a
type flows out to JS to that type's subtypes. It also did not consider
that types may flow out to JS via imports and exports. Fix these issues.