Increase Alpine stack size to 8MB#8595
Conversation
This reverts commit 0386aa3.
|
Test confirmed failing here on CI without the fix. Fix now applied, if it passes we should be good. |
There was a problem hiding this comment.
Maybe we could use the non-folded text format for this test to avoid the bonkers indentation, at least on the input.
There was a problem hiding this comment.
I feel the indentation is actually appropriate, as it shows the nesting which is the core problem here?
|
@tlively the fuzztest test is failing here, but I don't think it's related to this PR. Something to do with downloading from antlr.org - any idea? |
|
If it's not a transient failure, we could try updating the fuzztest submodule to see if the problem goes away with a more recent version. Backup options would be investigating building fuzztest without the antlr dependency or just disabling this builder. |
|
The alpine tests passed, confirming the fix. |
4 participants
The default in musl is apparently tiny, and MergeSimilarFunctions has
recursion which can hit it.
We can perhaps improve that pass to avoid recursion, but this change
seems generally good for robustness. It just makes us use the usual
8 MB stack size on Linux that all other Linuxes use.
Fixes #8594