[NFC] Simplify a bit of logic in RemoveUnusedBrs#8603
Merged
kripken merged 2 commits intoWebAssembly:mainfrom Apr 14, 2026
Merged
[NFC] Simplify a bit of logic in RemoveUnusedBrs#8603kripken merged 2 commits intoWebAssembly:mainfrom
kripken merged 2 commits intoWebAssembly:mainfrom
Conversation
tlively
approved these changes
Apr 14, 2026
Member
tlively
left a comment
There was a problem hiding this comment.
LGTM. Is it possible to find a test where would optimize now but not optimize before? Where the inner block result is a subtype of the outer block result, perhaps?
Member
Author
|
No, see |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The checks in the old code were not needed: we have a block that
has a single child, another block. Any branch to the child sends a
value that flows out to the parent immediately. No circumstances
exist in which we can error.
Also, this code only handles blocks without a value, so even
subtyping is not an issue here. (Merging blocks with different
types is handled elsewhere, RemoveUnusedNames, so no
need to add new logic here.)
Background:
https://github.com/WebAssembly/binaryen/pull/8398/changes/BASE..82441de8882abbac2a83bd88596c985d8c093b8e#r2861953106