Skip to content

Avoid assertion in BrOn parsing #8635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kripken merged 1 commit into from
Apr 21, 2026
+9 −0
Merged

Avoid assertion in BrOn parsing #8635

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/wasm/wasm-ir-builder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2093,6 +2093,15 @@ Result<> IRBuilder::makeBrOn(Index label,
}
CHECK_ERR(visitBrOn(&curr));

// Validate things that would cause errors later.
if (curr.ref->type != Type::unreachable && !curr.ref->type.isRef()) {
return Err{"br_on* ref must be a ref"};
}
if (curr.desc && curr.desc->type != Type::unreachable &&
!curr.desc->type.isRef()) {
return Err{"br_on_cast_desc* must be a ref"};
}

// Validate type immediates before we forget them.
switch (op) {
case BrOnNull:
Expand Down
Loading