wasm-reduce: Fix integer overflows#8665
Merged
kripken merged 7 commits intoWebAssembly:mainfrom May 4, 2026
Merged
Conversation
stevenfontanella
approved these changes
May 1, 2026
| std::unique_ptr<Builder> builder; | ||
| Index funcsSeen; | ||
| int factor; | ||
| size_t factor; |
Member
There was a problem hiding this comment.
Should we just make it uint64_t / int64_t if we're worried about overflowing a 32-bit int? I guess some systems may have 4 bytes for size_t?
Member
Author
There was a problem hiding this comment.
Hmm, I guess we could. I feel size_t reads a bit better, and a 32-bit system couldn't load a wasm file this large anyhow?
Member
There was a problem hiding this comment.
I usually prefer explicit sizes to not have to worry about differences in architecture, e.g. when reading I might wonder if the code works for 64-bit size_t but not for 32-bit size_t. I don't have a strong preference though, LGTM.
Member
Author
There was a problem hiding this comment.
Ok, I'm convinced. Changed to uint64_t.
stevenfontanella
approved these changes
May 2, 2026
tlively
approved these changes
May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a larger size than int, and be careful when multiplying by 9.
cc @tlively , I noticed that reducing a huge file - perhaps of a similar size as the one you were looking at - hit an overflow and immediately went to factor=1, which was extremely slow.