[wasm-split] Move shareImportableItems (NFC)#8686
Merged
aheejin merged 1 commit intoMay 11, 2026
Merged
Conversation
This just moves the function up in the file. A follow-up PR will change the order of functions and run it before `indirectReferencesToSecondaryFunctions`, so I'd like to match the order of the functions in the file to match that order, but if I move the function in that PR, it is hard to see what changes in the function.
Member
Author
|
The diff is really weird here. I just moved |
tlively
approved these changes
May 11, 2026
Member
tlively
left a comment
tlively
left a comment
There was a problem hiding this comment.
Sad that GitHub doesn't expose more diff algorithms that would make this more reasonable. I'll trust that this just moves the code, though 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just moves the function up in the file. A follow-up PR will change the order of functions and run it before
indirectReferencesToSecondaryFunctions, so I'd like to match the order of the functions in the file to match that order, but if I move the function in that PR, it is hard to see what changes in the function.