Skip to content

Use C++20 string_view starts_with/ends_with methods. NFC #8722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbc100 merged 1 commit into from
May 18, 2026
+2 −7
Merged

Use C++20 string_view starts_with/ends_with methods. NFC #8722

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions src/support/istring.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,7 @@ struct IString {
bool equals(std::string_view other) const { return str.view() == other; }

bool startsWith(std::string_view prefix) const {
// TODO: Use C++20 `starts_with`.
return view().substr(0, prefix.size()) == prefix;
return view().starts_with(prefix);
}
bool startsWith(IString other) const { return startsWith(other.view()); }

Expand All @@ -124,11 +123,7 @@ struct IString {
}

bool endsWith(std::string_view suffix) const {
// TODO: Use C++20 `ends_with`.
if (suffix.size() > str.size()) {
return false;
}
return view().substr(str.size() - suffix.size()) == suffix;
return view().ends_with(suffix);
}
bool endsWith(IString other) const { return endsWith(other.view()); }

Expand Down
Loading