[Fuzzer] Make Split's exports a list of strings#8731
Conversation
When the export name contains a comma, such as `foo<x,y>`, the v8 command does not work: ```colsole v8 ... exports:foo<x,y>,foo,bar,... --fuzz-split ``` This generates an `exports` as a list of strings within quotes, supporting export names with commas. This still parses the old format of `exports` in case it doesn't contain commas, which I think might be useful for handwritten command lines.
|
It's weird. Windows check hangs: https://github.com/WebAssembly/binaryen/actions/runs/26142999221/job/77013220649 |
|
The log says Does restarting the job help? |
|
Ah, maybe that was me. It took forever in the first try so I reran only that job in the CI panel but it also took forever so I merged |
|
I'll revert all changes in this PR just to make sure if my change is causing the issue. |
This reverts commit 49830a4.
|
Not all checks are finished but the Windows-11-arm is done already: https://github.com/WebAssembly/binaryen/actions/runs/26197299501/job/77079404504?pr=8731 So this change causes Windows-11-arm (but not Windows-latest) to hang.... Why.... |
This reverts commit ae55c72.
|
This windows run is also taking a while, so maybe there's some infra issue? https://github.com/WebAssembly/binaryen/actions/runs/26190799279/job/77058425164?pr=8625 |
|
Maybe this which just landed helps? #8749 |
When the export name contains a comma, such as
foo<x,y>, the v8 command does not work:This generates an
exportsas a list of strings within quotes, supporting export names with commas:This still parses the old format of
exportsin case it doesn't contain commas, which I think might be useful for handwritten command lines.