Revert "Fix open world public types"#8802
Merged
Merged
Conversation
This reverts commit 6bb9fe2.
Open
kripken
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #8792.
This change broke the fuzzer and real users due to an interaction between DAE optimizing private, non-referenced functions by introducing exact references in the parameters and results and MinimizeRecGroups expecting all public types (which now included the types of private, non-referenced functions) to be distinct, taking features into account.
Revert this change while we fix it to be more precise about which function types are public and to make sure the fuzzer is otherwise happy with it.