This repository was archived by the owner on Jan 15, 2025. It is now read-only.
Update interpreter and test suite for table64 #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
table64_interp
branch
3 times, most recently
from
d5fcb12 to
ce08751
Compare
|
I didn't end up duplicating all of the table.* tests here but just enough to get a little coverage for each instruction. Let me know if you think its worth duplicating more. |
rossberg
reviewed
May 1, 2024
alexcrichton
reviewed
May 2, 2024
There was a problem hiding this comment.
Poking at this I think there's one issue I flagged below, but mind also adding tests for table.copy? That'll likely want to inherit the same logic for memory.copy where the src/dst offsets have static types but the length-to-copy is the minimum of the two sizes.
| (table.init $t0 1 (i32.const 7) (i32.const 0) (i32.const 4))) | ||
| (table.init $t0 2 (i32.const 7) (i32.const 0) (i32.const 4))) | ||
| (func (export "test-t64") | ||
| (table.init $t64 2 (i32.const 7) (i32.const 0) (i32.const 4))) |
There was a problem hiding this comment.
I think this trailing i32.const needs to be i64.const?
There was a problem hiding this comment.
Thanks for catching.. taking a look now.
sbc100
pushed a commit
that referenced
this pull request
Aug 1, 2024
Add missing memory specifier to memory.init execution semantics
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.