This repository was archived by the owner on Dec 22, 2021. It is now read-only.
Accessing SIMD types form JavaScript throws #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@dtig @PeterJensen @binji please review. |
binji
reviewed
Oct 9, 2018
| subnormal result is rounded to 0. Note that this differs from WebAssembly | ||
| scalar floating-point semantics which require correct subnormal handling. | ||
|
|
||
| # JavaScript API and SIMD Values |
Member
There was a problem hiding this comment.
It looks like you can go through the js-api/index.bs doc and search for 𝗂𝟨𝟦, that has pretty much all the places you'll need to do the same thing.
The ones I see missing here:
- In
Globalconstructor - In
GetGlobalValue - In
Global.valueattribute
binji
reviewed
Oct 23, 2018
proposals/simd/SIMD.md
Outdated
|
|
||
| ### ToJSValue | ||
|
|
||
| The algorithm toJSValue(w) should have an assertion ensuring w is not of the form v129.const v128. |
proposals/simd/SIMD.md
Outdated
|
|
||
| ### Exported Globals | ||
|
|
||
| If an exported global is of type v128, throw a WebAssembly.LinkError |
proposals/simd/SIMD.md
Outdated
|
|
||
| ## WebAssembly Module Instatiation | ||
|
|
||
| Instantiating a WebAssembly Module from a Module moduleObject will throw a LinkError exception, when module_imports(moduleObject.[[Module]]) has an externtype of the form global mut valtype and valtype is v128. |
Member
There was a problem hiding this comment.
This is legal as long as the imported object's type is WebAssembly.Global and the global's valtype is v128.
Collaborator
Author
There was a problem hiding this comment.
Thanks, good catch :)
arunetm
force-pushed
the
proposal-simdValuesInJSInterface
branch
from
374b648 to
947153b
Compare
binji
approved these changes
Nov 8, 2018
proposals/simd/SIMD.md
Outdated
|
|
||
| ### Global constructor | ||
|
|
||
| If Global(descriptor, v) constructior will throw a [`TypeError`](https://tc39.github.io/ecma262/#sec-native-error-types-used-in-this-standard-typeerror), when invoked with v of valuetype v128. |
arunetm
force-pushed
the
proposal-simdValuesInJSInterface
branch
from
f347060 to
5613a7d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling out the expected behavior while accessing SIMD types from JS though JS API.
Ref: #9