Skip to content

Conversation

@dschuff
Copy link
Member

@dschuff dschuff commented Nov 5, 2025

Part of #1950, similarly to what was done with the memory64 core tests

Part of WebAssembly#1950, similarly to what was done with the memory64 core tests
@dschuff dschuff requested a review from Ms2ger November 5, 2025 23:54
@dschuff
Copy link
Member Author

dschuff commented Nov 5, 2025

Alternatively this could go into a separate directory to more strictly mirror the core tests...

@sbc100
Copy link
Member

sbc100 commented Nov 6, 2025

Is there any other proposal that did it this way for the js-api tests? Why single out memory64?

@dschuff
Copy link
Member Author

dschuff commented Nov 6, 2025

If there are others, it would make sense to do those too. I just started with memory64 because there's an interop proposal for memory64, so this is just to make it easier to specify which tests belong to that.

@dschuff
Copy link
Member Author

dschuff commented Nov 18, 2025

@sbc100 and/or @Ms2ger, you have any opinions about this?

Copy link
Collaborator

@Ms2ger Ms2ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm mildly negative about it - the design of testharness.js should be sufficient to track subtests if needed, but I won't block if you're convinced this is necessary.

@sbc100
Copy link
Member

sbc100 commented Nov 18, 2025

Same here, I'm kind of neutral, but if its needed to the interop 26 proposal then so be it!

@dschuff
Copy link
Member Author

dschuff commented Nov 20, 2025

The interop proposal is the most-direct cause of me wanting to work on this proposal in particular, but
it does seem like it would be good if the JS tests mirrored the organization of the core tests (see #1950), and more generally WPT's WEB_FEATURES.yml mechanism for associating tests with features only works at file granularity.
I'll merge this for now, but can you maybe say more about the testharness.js? You just mean that there's a mechanism to group tests into groups or subtests?

@dschuff dschuff merged commit 2929f44 into WebAssembly:main Nov 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants