Skip to content

Allow creation of default i64 global values#829

Merged
binji merged 2 commits into
masterfrom
global-i64
Jun 27, 2018
Merged

Allow creation of default i64 global values#829
binji merged 2 commits into
masterfrom
global-i64

Conversation

@binji
Copy link
Copy Markdown
Member

@binji binji commented Jun 24, 2018

See issue #827.

@binji binji requested a review from rossberg June 24, 2018 18:13
Copy link
Copy Markdown
Collaborator

@littledan littledan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo #827 (comment)

Is this going to go through the stage process, as the BigInt integration proposal is going through?

@binji
Copy link
Copy Markdown
Member Author

binji commented Jun 24, 2018

Good point, though this is a relatively minor change, we should discuss it in the CG.

@littledan
Copy link
Copy Markdown
Collaborator

I'm fine with it not going through a stage process, but process-wise, you might want to lay out a lightweight set of conditions for a tiny normative change like this to be added to the standard. For example, TC39 requires conformance tests for normative changes, even if they don't go through the stage process.

@binji
Copy link
Copy Markdown
Member Author

binji commented Jun 25, 2018

That's a good idea, though currently it seems that we've just taken a poll for changes like this. Perhaps there needs to be more for direct changes to the spec, however.

@lars-t-hansen
Copy link
Copy Markdown

IMO this needs a CG poll. While I agree this ought to be uncontroversial and I contemplated including this behavior when implementing globals in SpiderMonkey, it's a visible non-bug-fix spec change and should not quietly slip in.

@rossberg
Copy link
Copy Markdown
Member

I agree this should have a CG poll.

@binji
Copy link
Copy Markdown
Member Author

binji commented Jun 25, 2018

Added to tomorrow's CG, though the agenda is pretty full so it may be pushed to the next meeting.

@binji
Copy link
Copy Markdown
Member Author

binji commented Jun 26, 2018

We discussed this in the June 26th CG meeting and decided to include this change in the v1 spec.

@littledan
Copy link
Copy Markdown
Collaborator

Is this ready to merge then?

@binji binji merged commit c220352 into master Jun 27, 2018
@binji binji deleted the global-i64 branch June 27, 2018 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants