Skip to content

[jsapi] Update wasm-module-builder.js#979

Merged
backes merged 1 commit intoWebAssembly:masterfrom
backes:speed-up-module-builder
Mar 11, 2019
Merged

[jsapi] Update wasm-module-builder.js#979
backes merged 1 commit intoWebAssembly:masterfrom
backes:speed-up-module-builder

Conversation

@backes
Copy link
Copy Markdown
Member

@backes backes commented Mar 7, 2019

This speeds up the WasmModuleBuilder enormously. It follows this V8-side
CL: https://crrev.com/c/1508352
It also adopts a few other minor changes to the wasm-module-builder.js
file from the v8 side.

@backes backes requested a review from binji March 7, 2019 14:22
Copy link
Copy Markdown
Contributor

@xtuc xtuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sync'ing them.

Copy link
Copy Markdown
Member

@binji binji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, w/ some comments

@backes backes force-pushed the speed-up-module-builder branch 3 times, most recently from 98d0cc4 to eec74f6 Compare March 8, 2019 14:54
Copy link
Copy Markdown
Member

@binji binji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, w/ one nit

This speeds up the WasmModuleBuilder enormously. It follows this V8-side
CL: https://crrev.com/c/1508352
It also adopts a few other minor changes to the wasm-module-builder.js
file from the v8 side.
@backes backes force-pushed the speed-up-module-builder branch from eec74f6 to 782a4e9 Compare March 11, 2019 07:54
@backes backes merged commit e69482a into WebAssembly:master Mar 11, 2019
@backes backes deleted the speed-up-module-builder branch March 11, 2019 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants