[threads][js-api] Preserve SharedArrayBuffer identity on grow(0)#255
Open
backes wants to merge 1 commit intoWebAssembly:mainfrom
Open
[threads][js-api] Preserve SharedArrayBuffer identity on grow(0)#255backes wants to merge 1 commit intoWebAssembly:mainfrom
backes wants to merge 1 commit intoWebAssembly:mainfrom
Conversation
Update the JS-API spec to ensure that growing a shared memory by 0 pages does not recreate the SharedArrayBuffer object. This aligns with the Threads proposal overview and allows JS to check if growth actually occurred by comparing object identity. The spec'ed behavior now matches the implementation in all major browsers, as discussed in WebAssembly#248. - In "refresh the Memory buffer", return early if a shared memory's size hasn't changed. - Defer refreshing the buffer for shared memories until the "buffer" property or "toFixedLengthBuffer()" is accessed. This is a non-observable performance optimization that also ensures remote growth is picked up. - Maintain immediate refresh for unshared memories to ensure detachment. - Add explanatory notes and fix a minor typo. See WebAssembly#248.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the JS-API spec to ensure that growing a shared memory by 0 pages does not recreate the SharedArrayBuffer object. This aligns with the Threads proposal overview and allows JS to check if growth actually occurred by comparing object identity.
The spec'ed behavior now matches the implementation in all major browsers, as discussed in #248.
See #248.