Skip to content

Add names to locally declared globals. #1057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbc100 merged 1 commit into from
Apr 4, 2019
Merged

Add names to locally declared globals. #1057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/binary-reader-objdump.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1225,6 +1225,10 @@ Result BinaryReaderObjdump::OnGlobalCount(Index count) {
Result BinaryReaderObjdump::BeginGlobal(Index index, Type type, bool mutable_) {
PrintDetails(" - global[%" PRIindex "] %s mutable=%d", index,
GetTypeName(type), mutable_);
string_view name = GetGlobalName(index);
if (!name.empty()) {
PrintDetails(" <" PRIstringview ">", WABT_PRINTF_STRING_VIEW_ARG(name));
}
return Result::Ok;
}

Expand Down
2 changes: 1 addition & 1 deletion test/dump/mutable-global.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ Section Details:
Import[1]:
- global[0] i32 mutable=1 <- foo.imported
Global[1]:
- global[1] i32 mutable=1 - init i32=1
- global[1] i32 mutable=1 <exported> - init i32=1
Export[1]:
- global[1] -> "exported"

Expand Down