Add support for new WASM_SYMBOL_ABS symbol flag #2305
Merged
+26
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
add_symbol_flag
branch
from
426cd14 to
2e3c7ca
Compare
keithw
approved these changes
Sep 27, 2023
Member
keithw
left a comment
keithw
left a comment
There was a problem hiding this comment.
lgtm. I guess in an ideal world maybe there would be some sort of common testsuite for the tool-conventions...
Member
|
@sbc100 Should we merge this? |
Member
Author
|
Yup! Not sure why I didn't already. Updated and set auto-merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See llvm/llvm-project#67493