The great renaming #985
Merged
The great renaming #985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This huge PR does all the renaming as described in issue #933. It also updates to the latest testsuite so the new names are used. The old names of the MVP instructions are still supported for convenience (though we should remove those too at some point), but the old simd and atomic instruction names are no longer supported.
|
Is there a command line switch to disable the old naming? Also for libwabt.js? Without such switch it is difficult to check if the migration is 100% complete. |
Member
Author
|
There isn't, but you're right that would be a convenient switch to add. I'll look into that today. |
Member
Author
|
I think I'll handle that flag in another PR, to keep this change as being primarily renaming. |
alexcrichton
added a commit
to alexcrichton/threads
that referenced
this pull request
Feb 13, 2019
binji
pushed a commit
to WebAssembly/threads
that referenced
this pull request
Feb 13, 2019
|
Are there plans to push these changes to the wat2wasm demo? https://cdn.rawgit.com/WebAssembly/wabt/aae5a4b7/demo/wat2wasm/ When I try using local.get rather than get_local, I receive the following error: |
Member
Author
|
@cggallant that is an old link, back when we used rawgit (which is being turned down). The new link is https://webassembly.github.io/wabt/demo/wat2wasm/, and supports the new and old names. |
aheejin
added a commit
to aheejin/wabt
that referenced
this pull request
Dec 19, 2021
This finishes WebAssembly#985 by dropping support for the deprecated names and update old names in tests. WebAssembly#985 says the old names are supported for convenience but we should remove those too at some point; that "some point" may have well arrived given that three years have passed. The list of names updated is in WebAssembly#933 and WebAssembly#1564.
aheejin
added a commit
to aheejin/wabt
that referenced
this pull request
Dec 19, 2021
This finishes WebAssembly#985. This - replaces renaming the old names in the tests with the new names - updates more instruction names: `memory.size` and `memory.grow` - drops support for the deprecated names - renames test files to match new instruction names I don't think dropping support for the old names will be a problem at this point. WebAssembly#985 says the old names are supported for convenience but we should remove those too at some point; that "some point" may have well arrived given that three years have passed. The lists of names updated are in WebAssembly#933, WebAssembly#1564, WebAssembly/spec#720.
aheejin
added a commit
to aheejin/wabt
that referenced
this pull request
Dec 20, 2021
This finishes WebAssembly#985. This - replaces renaming the old names in the tests with the new names - updates more instruction names: `memory.size` and `memory.grow` - drops support for the deprecated names - renames test files to match new instruction names I don't think dropping support for the old names will be a problem at this point. WebAssembly#985 says the old names are supported for convenience but we should remove those too at some point; that "some point" may have well arrived given that three years have passed. The lists of names updated are in WebAssembly#933, WebAssembly#1564, WebAssembly/spec#720.
aheejin
added a commit
to aheejin/wabt
that referenced
this pull request
Dec 20, 2021
This finishes WebAssembly#985. This - replaces the old names in the tests with the new names - drops support for the deprecated names - renames test files to match new instruction names I don't think dropping support for the old names will be a problem at this point. WebAssembly#985 says the old names are supported for convenience but we should remove those too at some point; that "some point" may have well arrived given that three years have passed. The lists of names updated are in WebAssembly#933, WebAssembly#1564, WebAssembly/spec#720.
aheejin
added a commit
that referenced
this pull request
Dec 21, 2021
This finishes #985. This - replaces the old names in the tests with the new names - drops support for the deprecated names - renames test files to match new instruction names I don't think dropping support for the old names will be a problem at this point. #985 says the old names are supported for convenience but we should remove those too at some point; that "some point" may have well arrived given that three years have passed. The lists of names updated are in #933, #1564, WebAssembly/spec#720.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This huge PR does all the renaming as described in issue #933. It also
updates to the latest testsuite so the new names are used.
The old names of the MVP instructions are still supported for
convenience (though we should remove those too at some point), but the
old simd and atomic instruction names are no longer supported.