Avoid varargs conventions when calling open#126
Merged
sunfishcode merged 2 commits intomasterfrom Nov 5, 2019
Merged
Conversation
sunfishcode
force-pushed
the
po-opt-more
branch
from
2ef19b9 to
bbb0b75
Compare
Member
Author
|
#110 has now landed, and this is now rebased, so this is ready for review! |
sbc100
approved these changes
Nov 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Varargs calls take more code space, and for
open, aren't strictly necessary. Marking as a draft, as this depends on #110.