Don't pre-check capabilities in openat.#130
Merged
sunfishcode merged 1 commit intomasterfrom Nov 10, 2019
Merged
Conversation
Rely on the WASI implementation to check capabilities flags, rather than also checking them in the userspace `openat` implementation. This code is admittedly getting fairly dense with `#ifdef`s, so it may soon make sense to move this file out of the `cloudlibc` directory and removing the upstream change markers.
sunfishcode
force-pushed
the
optimize-openat
branch
from
6d9a7d1 to
4380a61
Compare
mikevoronov
approved these changes
Nov 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rely on the WASI implementation to check capabilities flags, rather
than also checking them in the userspace
openatimplementation.This code is admittedly getting fairly dense with
#ifdefs, so itmay soon make sense to move this file out of the
cloudlibcdirectory and removing the upstream change markers.