Use consistent style for wasi-libc C source files.#131
Merged
sunfishcode merged 1 commit intomasterfrom Nov 8, 2019
Merged
Conversation
For now, this means using `//`-style comments in .c source files (though not public header files), and spaces rather than tabs. No strong opinion here; this is just what the majority of the current code is using. This also synchronizes basics/crt/crt1.c with libc-bottom-half's version, though this is just a cleanup as the former isn't currently used by the main wasi-libc build.
mikevoronov
approved these changes
Nov 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now, this means using
//-style comments in .c source files (thoughnot public header files), and spaces rather than tabs. No strong opinion
here; this is just what the majority of the current code is using.
This also synchronizes basics/crt/crt1.c with libc-bottom-half's
version, though this is just a cleanup as the former isn't currently used
by the main wasi-libc build.
cc @michaelvoronov This follows up on #116. It isn't a guide per se, but it does make things more consistent.