threads: implement support for conditional variables#323
Merged
abrown merged 1 commit intoWebAssembly:mainfrom Sep 6, 2022
Merged
threads: implement support for conditional variables#323abrown merged 1 commit intoWebAssembly:mainfrom
abrown merged 1 commit intoWebAssembly:mainfrom
Conversation
sbc100
reviewed
Sep 5, 2022
| unlock_requeue(&node.prev->barrier, &m->_m_lock, m->_m_type & (8|128)); | ||
| } else if (!(m->_m_type & 8)) { | ||
| a_dec(&m->_m_waiters); | ||
| a_dec(&m->_m_waiters); |
Member
There was a problem hiding this comment.
revert these 3 whitespace-only changes?
Contributor
Author
There was a problem hiding this comment.
I guess that's to keep the source as close to musl as possible? I've reverted that (and two similar) changes.
loganek
force-pushed
the
loganek/pthread_cond
branch
3 times, most recently
from
58bb614 to
51937f5
Compare
Collaborator
|
Rebase now that #320 is merged? |
The implementation is not as efficient as for native Linux platform due to lack of FUTEX_REQUEUE-like system call in WASI. For now we wake all the waiters which is inefficient; if that becomes a bottleneck, I suggest we'll revisit the implementation.
loganek
force-pushed
the
loganek/pthread_cond
branch
from
51937f5 to
f10a3e9
Compare
Contributor
Author
|
@abrown rebased |
abrown
approved these changes
Sep 6, 2022
john-sharratt
pushed a commit
to john-sharratt/wasix-libc
that referenced
this pull request
Mar 6, 2023
The implementation is not as efficient as for native Linux platform due to lack of FUTEX_REQUEUE-like system call in WASI. For now we wake all the waiters which is inefficient; if that becomes a bottleneck, I suggest we'll revisit the implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation is not as efficient as for native Linux platform due
to lack of FUTEX_REQUEUE-like system call in WASI.
For now we wake all the waiters which is inefficient; if that becomes
a bottleneck, I suggest we'll revisit the implementation.
The change is built on top of #320