threads: enable pthread_join#336
Merged
abrown merged 1 commit intoWebAssembly:mainfrom Oct 10, 2022
Merged
Conversation
sbc100
approved these changes
Oct 10, 2022
abrown
approved these changes
Oct 10, 2022
Collaborator
abrown
left a comment
abrown
left a comment
There was a problem hiding this comment.
LGTM; I have some doubts about whether __pthread_setcancelstate here even needs to be (or should be) called but I think it is fine for now. And this free looks right; the pthread_create is doing the malloc.
john-sharratt
pushed a commit
to john-sharratt/wasix-libc
that referenced
this pull request
Mar 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.