Fix alignment of poll subscriptions#42
Merged
abrown merged 1 commit intoWebAssembly:mainfrom Feb 28, 2023
Merged
Conversation
_Alignof(__wasi_subscription_t) is 8. wasmtime actually rejects misaligned addresses. The problem pointed out by sunfishcode: bytecodealliance/wasmtime#5891 (comment) Fixes WebAssembly#39
abrown
approved these changes
Feb 28, 2023
Collaborator
abrown
left a comment
abrown
left a comment
There was a problem hiding this comment.
I can confirm this does fix the issue. I now see:
$ TEST_RUNTIME_EXE="wasmtime --wasm-features=threads --wasi-modules=experimental-wasi-threads" python wasi-testsuite/test-runner/wasi_test_runner.py -r wasi-testsuite/adapters/wasmtime.py -t wasi-threads/test/testsuite/
Test wasi_threads_exit_main_block passed
Test wasi_threads_exit_main_busy passed
Test wasi_threads_exit_main_wasi passed
Test wasi_threads_exit_nonmain_block passed
Test wasi_threads_exit_nonmain_busy passed
Test wasi_threads_exit_nonmain_wasi passed
Test wasi_threads_spawn passed
===== Test results =====
Runtime: wasmtime-cli 7.0.0
Suite: WASI threads proposal
Total: 7
Passed: 7
Failed: 0
Skipped: 0
Test suites: 1 passed, 0 total
Tests: 7 passed, 0 total
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_Alignof(__wasi_subscription_t) is 8. wasmtime actually rejects misaligned addresses.
The problem pointed out by sunfishcode:
bytecodealliance/wasmtime#5891 (comment)
Fixes #39